[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2()
    On Apr 6, 2012, at 10:44 AM, Chris Wilson wrote:

    > That I agreed with, I just disagree with how you chose to handle it.
    > Rather than continue on and attempt to vmalloc a large array we should
    > just fail the ioctl with EINVAL.

    Why an attempt to vmalloc? The overflow check in drm_malloc_ab()
    will simply return NULL and fail the ioctl with -ENOMEM.

    - xi

     \ /
      Last update: 2012-04-06 20:19    [W:0.031 / U:42.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site