lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/1] Renaming AMBA to PRIMECELL
On 04/05/2012 05:21 PM, Alessandro Rubini wrote:
> The only patch in this series renames CONFIG_ARM_AMBA to
> CONFIG_ARM_PRIMECELL in Kconfig and the only source file with
> #ifdef.
>
> I compile-tested on the following defconfigs: "integrator realview
> versatile vexpress bcmring ep93xx lpc32xx u300 u8500 nhk8815 spear3xx
> spear6xx", diffing the stderr of the two compilations.
>
> While this patch is self-contained and works, there are other
> open points. I think only 4- below is worth doing, but I need
> confirmation before doing that.
>
> 1- drivers/of/platform.c still has "amba" in its names. Worse, it has
> "amba-bus" in its device tree compatibility list (and some drivers
> have it too). I think this should stay.
>
> 2- Actually, grepping for "amba" or "AMBA" finds a lot of related
> code. Some uses are correct and some are not. I don't think an
> audit here is worth the effort; users will adapt over time, only
> where it makes sense and only when otherwise touching the code.
>
> 3- Should drivers/amba/bus.c be renamed to drivers/primecell/bus.c
> or drivers/amba/primecell.c (I think the former but I'm not sure
> it's the bext name anyways)
>
> 4- Should linux/amba/bus.h be renamed to linux/primecell/bus.h or
> linux/amba/primecell.h? (I think the former, leaving the old
> name around for a while, so out-of-tree drivers are happy
> and #warn'ed about the change.
>
> /alessandro
>

While I agree this is a more correct name, I think this is pointless
churn and as you highlight above incomplete. What's the reasoning for
this other than rmk suggested it?

Rob

>
>
> Alessandro Rubini (1):
> ARM: Rename CONFIG_ARM_AMBA to CONFIG_ARM_PRIMECELL
>
> arch/arm/Kconfig | 36 ++++++++++++++++++++++--------------
> arch/arm/Kconfig.debug | 2 +-
> arch/arm/mach-exynos/Kconfig | 4 ++--
> arch/arm/mach-mxs/devices/Kconfig | 2 +-
> arch/arm/mach-netx/Kconfig | 4 ++--
> arch/arm/mach-omap2/Kconfig | 2 +-
> arch/arm/plat-samsung/Kconfig | 2 +-
> drivers/Makefile | 2 +-
> drivers/dma/Kconfig | 4 ++--
> drivers/gpio/Kconfig | 2 +-
> drivers/input/serio/Kconfig | 2 +-
> drivers/mmc/host/Kconfig | 2 +-
> drivers/of/platform.c | 10 +++++-----
> drivers/rtc/Kconfig | 4 ++--
> drivers/spi/Kconfig | 2 +-
> drivers/tty/serial/Kconfig | 4 ++--
> drivers/video/Kconfig | 2 +-
> drivers/watchdog/Kconfig | 2 +-
> sound/arm/Kconfig | 2 +-
> 19 files changed, 49 insertions(+), 41 deletions(-)
>



\
 
 \ /
  Last update: 2012-04-06 19:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site