lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2()
    Date
    On Fri, 6 Apr 2012 09:46:46 -0400, Xi Wang <xi.wang@gmail.com> wrote:
    > On Apr 6, 2012, at 9:36 AM, Chris Wilson wrote:
    >
    > > On Fri, 6 Apr 2012 08:58:18 -0400, Xi Wang <xi.wang@gmail.com> wrote:
    > >> A large args->buffer_count from userspace may overflow the allocation
    > >> size, leading to out-of-bounds access.
    > >>
    > >> Use kmalloc_array() to avoid that.
    > >
    > > I can safely say that exec list larger than 4GiB is going to be an
    > > illegal operation and would rather the ioctl failed outright with
    > > EINVAL.
    >
    > On 32-bit platform?

    On any platform. The largest it can legally be is a few tens of megabytes.
    -Chris

    --
    Chris Wilson, Intel Open Source Technology Centre


    \
     
     \ /
      Last update: 2012-04-06 15:57    [W:0.019 / U:88.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site