lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/15] events: Update tools/lib/traceevent to work with perf
    On Fri, Apr 06, 2012 at 12:47:55AM +0200, Frederic Weisbecker wrote:
    > From: Steven Rostedt <srostedt@redhat.com>
    >
    > Some of the util functions of libtraceevent.a conflict with perf,
    > such as die(), warning() and others. Move them into event-util.h

    Minor: judging by the patch below, you mean "event-utils.h" here.

    > that is not included by the perf tools.
    >
    > Also, as perf compiles with 'bool' the filter_arg->bool needs to
    > be renamed to filter_arg->boolean.
    >
    > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > Cc: Ingo Molnar <mingo@kernel.org>
    > Cc: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Peter Zijlstra <peterz@infradead.org>
    > Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
    > Cc: Steven Rostedt <rostedt@goodmis.org>
    > Cc: Borislav Petkov <bp@alien8.de>
    > Cc: Jiri Olsa <jolsa@redhat.com>
    > Cc: Arun Sharma <asharma@fb.com>
    > Cc: Namhyung Kim <namhyung.kim@lge.com>
    > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    > ---
    > tools/lib/traceevent/event-parse.c | 1 +
    > tools/lib/traceevent/event-parse.h | 20 +++-----------------
    > tools/lib/traceevent/event-utils.h | 16 ++++++++++++++++
    > tools/lib/traceevent/parse-filter.c | 32 ++++++++++++++++----------------
    > tools/lib/traceevent/trace-seq.c | 1 +
    > 5 files changed, 37 insertions(+), 33 deletions(-)
    >
    > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
    > index 47a3227..3ce75b5 100644
    > --- a/tools/lib/traceevent/event-parse.c
    > +++ b/tools/lib/traceevent/event-parse.c
    > @@ -33,6 +33,7 @@
    > #include <errno.h>
    >
    > #include "event-parse.h"
    > +#include "event-utils.h"

    ^^^^^^^^^^^^^

    --
    Regards/Gruss,
    Boris.


    \
     
     \ /
      Last update: 2012-04-06 13:51    [W:0.023 / U:30.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site