lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead
    On Thu, 5 Apr 2012, Andreas Schwab wrote:
    > Grant Likely <grant.likely@secretlab.ca> writes:
    >
    > > I bet it is NR_IRQS related. You have SPARSE_IRQ enabled, which means
    > > the maximum number of irq_descs is IRQ_BITMAP_BITS (NR_IRQS + 8192).
    >
    > The actual definition uses NR_IRQS + 8196. Guess that's a typo. (Does
    > it really make sense to add NR_IRQS here?)
    >
    > > diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h
    > > index cf417e51..9edf499 100644
    > > --- a/arch/powerpc/include/asm/irq.h
    > > +++ b/arch/powerpc/include/asm/irq.h
    > > @@ -20,7 +20,7 @@
    > >
    > > /* Define a way to iterate across irqs. */
    > > #define for_each_irq(i) \
    > > - for ((i) = 0; (i) < NR_IRQS; ++(i))
    > > + for ((i) = 0; (i) < nr_irqs; ++(i))
    >
    > There are exactly two uses of for_each_irq, one is related to cpu
    > hotplug, the other to kexec, so that cannot make any difference.

    Though that wants to be fixed nevertheless.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2012-04-06 13:15    [W:0.020 / U:29.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site