lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/5] perf annotate: Fix hist decay
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    We were only decaying the entries for the offsets that were associated
    with an objdump line.

    That way, when we accrued the whole instruction addr range, more than
    100% was appearing in some cases in the live annotation TUI.

    Fix it by not traversing the source code line at all, just iterate thru
    the complete addr range decaying each one.

    Reported-by: Mike Galbraith <mgalbraith@suse.de>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-hcae5oxa22syjrnalsxz7s6n@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/annotate.c | 12 ++++--------
    1 file changed, 4 insertions(+), 8 deletions(-)

    diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
    index 199f69e..70f5a4d 100644
    --- a/tools/perf/util/annotate.c
    +++ b/tools/perf/util/annotate.c
    @@ -561,16 +561,12 @@ void symbol__annotate_decay_histogram(struct symbol *sym, int evidx)
    {
    struct annotation *notes = symbol__annotation(sym);
    struct sym_hist *h = annotation__histogram(notes, evidx);
    - struct objdump_line *pos;
    - int len = sym->end - sym->start;
    + int len = sym->end - sym->start, offset;

    h->sum = 0;
    -
    - list_for_each_entry(pos, &notes->src->source, node) {
    - if (pos->offset != -1 && pos->offset < len) {
    - h->addr[pos->offset] = h->addr[pos->offset] * 7 / 8;
    - h->sum += h->addr[pos->offset];
    - }
    + for (offset = 0; offset < len; ++offset) {
    + h->addr[offset] = h->addr[offset] * 7 / 8;
    + h->sum += h->addr[offset];
    }
    }

    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-04-06 01:33    [W:0.022 / U:1.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site