lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] ixgbe: add missing rtnl_lock in PM resume path
    From
    Date
    On Thu, 2012-04-05 at 11:11 -0400, Benjamin Poirier wrote:
    > Upon resume from standby, ixgbe may trigger the ASSERT_RTNL() in
    > netif_set_real_num_tx_queues(). The call stack is:
    > netif_set_real_num_tx_queues
    > ixgbe_set_num_queues
    > ixgbe_init_interrupt_scheme
    > ixgbe_resume
    >
    > Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
    >
    > ---
    > Unlike patch 1 for igb, we cannot lock rtnl closer to the point where
    > netif_set_real_num_tx_queues() is called because
    > ixgbe_init_interrupt_scheme()
    > is also called by the dcb code, already under rtnl.
    > ---
    > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 ++
    > 1 files changed, 2 insertions(+), 0 deletions(-)

    Thanks Benjamin, I will add the patch to my igb queue of patches.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-04-06 01:05    [W:0.020 / U:0.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site