lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drxk: Does not unlock mutex if sanity check failed in scu_command()
    Date
    If sanity check fails in scu_command(), goto error leads to unlock of
    an unheld mutex. The check should not fail in reality, but it nevertheless
    worth fixing.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    ---
    drivers/media/dvb/frontends/drxk_hard.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c
    index 6980ed7..3cce362 100644
    --- a/drivers/media/dvb/frontends/drxk_hard.c
    +++ b/drivers/media/dvb/frontends/drxk_hard.c
    @@ -1525,8 +1525,10 @@ static int scu_command(struct drxk_state *state,
    dprintk(1, "\n");

    if ((cmd == 0) || ((parameterLen > 0) && (parameter == NULL)) ||
    - ((resultLen > 0) && (result == NULL)))
    - goto error;
    + ((resultLen > 0) && (result == NULL))) {
    + printk(KERN_ERR "drxk: Error %d on %s\n", status, __func__);
    + return status;
    + }

    mutex_lock(&state->mutex);

    --
    1.7.4.1


    \
     
     \ /
      Last update: 2012-04-06 00:55    [W:0.021 / U:0.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site