Messages in this thread | | | Date | Thu, 5 Apr 2012 19:51:48 +0300 | From | Ilya Dryomov <> | Subject | Re: [PATCH v2] Btrfs, lockdep: get_restripe_target: use lockdep in BUG_ON |
| |
On Thu, Apr 05, 2012 at 12:23:01PM -0400, Bobby Powers wrote: > On Wed, Apr 4, 2012 at 10:04 PM, Bobby Powers <bobbypowers@gmail.com> wrote: > > spin_is_locked always returns 0 on non-SMP systems, which causes btrfs > > to fail the mount. There is documentation pending as to why checking > > I guess I should be explicit in stating that this is a regression, so > this patch or something else that addresses it should be pulled into > 3.4.
Yes, this is a regression and spin_is_locked() definitely has to go. I don't have a strong opinion on this assert, if there are objections to v2 I'm OK with ripping that BUG_ON entirely and replacing it with a comment (this function and its callers are WIP).
Thanks,
Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |