lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] toshiba_acpi: Add support for transflective LCD
Seth Forshee wrote:

> I'm still not crazy about the name. And really I think if
> get_tr_backlight_status() is going to return an error code, when it
> fails the return value should be propogated (even if it's the same in
> this case). How about this?


Thank you for your suggestion. I agree with you. I'll try to make a
new patch again.

>> static const struct backlight_ops toshiba_backlight_data = {
>> + .options = BL_CORE_SUSPENDRESUME,
>
> What's the reason for adding this? I don't see that it's useful unless
> we're handling BL_CORE_SUSPENDED, which toshiba_acpi is not doing.


The reason is to restore transflective status, which is always disabled
after resuming. If BL_CORE_SUSPENDRESUME is added,
set_lcd_state_status() is called from backlight_update_status() with
stored brightness. So, when its brightness is 0, transflective status is
enabled after resuming.


Best Regards,
Akio


\
 
 \ /
  Last update: 2012-04-05 16:39    [W:0.048 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site