lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] sound/pci/hda: CX20549 doesn't need pin_amp_workaround.
At Thu, 05 Apr 2012 15:30:35 +0200,
Michael Karcher wrote:
>
> CX20549 (ctx5045) doesn't accept data on index 1 for output pins,
> as shown in the following hda-var transaction:
>
> $ hda-verb /dev/snd/hwC0D0 0x10 set_amp_gain 0xb126
> nid = 0x10, verb = 0x300, param = 0xb126
> value = 0x0
> $ hda-verb /dev/snd/hwC0D0 0x10 get_amp_gain 0x8001
> nid = 0x10, verb = 0xb00, param = 0x8001
> value = 0x0

OK, it's good to know. Could you fix it in the corresponding part in
patch_conexant_auto(), too?


Takashi

> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 8d7a977..3ab7b25 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -1087,7 +1087,6 @@ static int patch_cxt5045(struct hda_codec *codec)
> if (!spec)
> return -ENOMEM;
> codec->spec = spec;
> - codec->pin_amp_workaround = 1;
>
> spec->multiout.max_channels = 2;
> spec->multiout.num_dacs = ARRAY_SIZE(cxt5045_dac_nids);
> --
> 1.7.9.1
>
>
>


\
 
 \ /
  Last update: 2012-04-05 16:35    [W:0.043 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site