lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] regulator: isl6271a: Allow missing init_data for diagnostics
Date
Dear Mark Brown,

> The regulator core supports this to allow the configuration to be inspected
> at runtime even if no software mangement is enabled.

Acked-by: Marek Vasut <marek.vasut@gmail.com>

>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/isl6271a-regulator.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/regulator/isl6271a-regulator.c
> b/drivers/regulator/isl6271a-regulator.c index 775f5fd..a0430aa 100644
> --- a/drivers/regulator/isl6271a-regulator.c
> +++ b/drivers/regulator/isl6271a-regulator.c
> @@ -140,6 +140,7 @@ static struct regulator_desc isl_rd[] = {
> static int __devinit isl6271a_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> + struct regulator_config config = { };
> struct regulator_init_data *init_data = i2c->dev.platform_data;
> struct isl_pmic *pmic;
> int err, i;
> @@ -147,11 +148,6 @@ static int __devinit isl6271a_probe(struct i2c_client
> *i2c, if (!i2c_check_functionality(i2c->adapter,
> I2C_FUNC_SMBUS_BYTE_DATA)) return -EIO;
>
> - if (!init_data) {
> - dev_err(&i2c->dev, "no platform data supplied\n");
> - return -EIO;
> - }
> -
> pmic = kzalloc(sizeof(struct isl_pmic), GFP_KERNEL);
> if (!pmic)
> return -ENOMEM;

Best regards,
Marek Vasut


\
 
 \ /
  Last update: 2012-04-04 09:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site