lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] umem: fix up unplugging.
On Wed, Apr 4, 2012 at 4:18 PM, Jens Axboe <axboe@kernel.dk> wrote:
> On 2012-04-04 16:20, Tao Guo wrote:
>> Hi Andrew,
>>
>> Thanks for your reply.
>>
>> Yes, without this patch the umem driver just doesn't work.
>> It is a bug introduced by commit 7eaceaccab5f40bbfda044629a6298616aeaed50.
>> In that patch, Jens removed the whole mm_unplug_device() function,
>> which used to be
>> the trigger to make umem start to work.
>
> Hmm indeed, that's isn't terribly useful. Why aren't we just calling
> activate_card() on addition of a bio?
>
It is the original design idea, the umem driver also wants to do batch
IO the same as
hard disk drive to fully utilize the IO bandwidth.

Thanks,
-Tao
> But your patch looks fine too, if it's tested it beats what we have.
>
> --
> Jens Axboe
>


\
 
 \ /
  Last update: 2012-04-05 02:01    [W:0.094 / U:2.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site