lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] umem: fix up unplugging.
On 2012-04-04 16:20, Tao Guo wrote:
> Hi Andrew,
>
> Thanks for your reply.
>
> Yes, without this patch the umem driver just doesn't work.
> It is a bug introduced by commit 7eaceaccab5f40bbfda044629a6298616aeaed50.
> In that patch, Jens removed the whole mm_unplug_device() function,
> which used to be
> the trigger to make umem start to work.

Hmm indeed, that's isn't terribly useful. Why aren't we just calling
activate_card() on addition of a bio?

But your patch looks fine too, if it's tested it beats what we have.

--
Jens Axboe



\
 
 \ /
  Last update: 2012-04-05 01:21    [from the cache]
©2003-2011 Jasper Spaans