Messages in this thread Patch in this message | | | From | Stephen Warren <> | Subject | [PATCH 6/6] regmap: prevent division by zero in rbtree_show | Date | Wed, 4 Apr 2012 15:48:33 -0600 |
| |
From: Stephen Warren <swarren@nvidia.com>
If there are no nodes in the cache, nodes will be 0, so calculating "registers / nodes" will cause division by zero.
Signed-off-by: Stephen Warren <swarren@nvidia.com> --- drivers/base/regmap/regcache-rbtree.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c index 9eea758..e49e71f 100644 --- a/drivers/base/regmap/regcache-rbtree.c +++ b/drivers/base/regmap/regcache-rbtree.c @@ -138,6 +138,7 @@ static int rbtree_show(struct seq_file *s, void *ignored) unsigned int base, top; int nodes = 0; int registers = 0; + int average; map->lock(map); @@ -152,8 +153,13 @@ static int rbtree_show(struct seq_file *s, void *ignored) registers += top - base + 1; } + if (nodes) + average = registers / nodes; + else + average = 0; + seq_printf(s, "%d nodes, %d registers, average %d registers\n", - nodes, registers, registers / nodes); + nodes, registers, average); map->unlock(map); -- 1.7.0.4
| |