lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] userns: Replace netlink uses of cap_raised with capable.
On Tue, 3 Apr 2012, Eric W. Biederman wrote:

> In the initial user_namespace the only difference between between
> cap_raised(current_cap(), CAP_SYS_ADMIN) and capable(CAP_SYS_ADMIN)
> are a few sanity checks and the fact that capable(CAP_SYS_ADMIN)
> sets PF_SUPERPRIV if we use the capability.
>
> Since we are going to be using root privilege setting PF_SUPERPRIV
> seems the right thing to do.

Agreed.

Reviewed-by: James Morris <james.l.morris@oracle.com>


- James
--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2012-04-04 06:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site