lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] ARM: OMAP2+: SmartReflex: move the driver specific macros in include/linux/power
    On 4/4/2012 9:10 PM, Trilok Soni wrote:
    > Hi Jean,
    >
    > On 3/19/2012 9:42 PM, jean.pihet@newoldbits.com wrote:
    >> From: Jean Pihet<j-pihet@ti.com>
    >>
    >> Move the driver specific macros from the smartreflex header file
    >> (arch/arm/mach-omap2/smartreflex.h) in a new header file
    >> include/linux/power/smartreflex.h.
    >>
    >> This change makes the SmartReflex implementation ready for the move
    >> to drivers/.
    >
    > I wonder why someone would need a new directory under drivers/power
    > where the code is not about introducing new and generic AVS framework
    > but it is all about OMAP specific code.

    The main motivation is that it's a driver and thus does not have
    anything to do inside mach-omap2.

    Where will you put that otherwise?

    > What if tomorrow new generic
    > AVS framework comes from different chip vendor? I am sure this kind
    > of technology would be common in newer embedded chips.

    Probably, but this is hard to know with only one implementation so far
    in the kernel.
    I guess when someone else will start pushing some new AVS driver inside
    the AVS directory, we might realize that there is enough common part to
    create a frwmk.

    IIRC, David Brownell was referring to the rule of three for such case.
    Meaning that it worth having a generic fmwk when at least three
    different drivers are doing the same kind of things.

    Regards,
    Benoit


    \
     
     \ /
      Last update: 2012-04-04 21:43    [W:0.022 / U:0.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site