Messages in this thread | | | Date | Mon, 30 Apr 2012 20:51:28 +0200 | Subject | Re: [PATCH v3 5/6] hid-multitouch: Switch to device groups | From | Benjamin Tissoires <> |
| |
On Mon, Apr 30, 2012 at 20:30, Henrik Rydberg <rydberg@euromail.se> wrote: >> I remarked a small regression in this patch: the detection of the >> serial protocol is not handled anymore. I was indeed relying on the >> fact that the parameter "id" in mt_probe was null to know that the >> device was not already in the list of known devices. > > I see. Will this suffice?
Yes, but I'd rather do the test against either id->product or id->driver_data as we may use HID_ANY_ID for vendors specific handling. For instance, I had the confirmation from EETI (eGalax) that they will always use the same protocol for their usb products, thus the same quirks could be handled by HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH, USB_VENDOR_ID_DWAV, HID_ANY_ID).
Thanks, Benjamin
> > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 125c1e7..507981e 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -673,8 +673,8 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id) > if (ret) > goto fail; > > - if (!id && td->touches_by_report == 1) { > - /* the device has been sent by hid-generic */ > + /* unknown serial devices need special quirks */ > + if ((!id || id->product == HID_ANY_ID) && td->touches_by_report == 1) { > mtclass = &td->mtclass; > mtclass->quirks |= MT_QUIRK_ALWAYS_VALID; > mtclass->quirks &= ~MT_QUIRK_NOT_SEEN_MEANS_UP; > > Cheers, > Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |