lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/5] powerpc: dts: klondike: Add UART nodes
    From
    On Tue, Apr 3, 2012 at 11:57 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
    > On Mon,  2 Apr 2012 12:09:05 +0530, Tanmay Inamdar <tinamdar@apm.com> wrote:
    >> Adding UART nodes in Klondike device tree file.
    >>
    >> Signed-off-by: Tanmay Inamdar <tinamdar@apm.com>
    >> ---
    >> :100644 100644 4ff2852... d5bf2e1... M        arch/powerpc/boot/dts/klondike.dts
    >>  arch/powerpc/boot/dts/klondike.dts |   24 ++++++++++++++++++++++++
    >>  1 files changed, 24 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/arch/powerpc/boot/dts/klondike.dts b/arch/powerpc/boot/dts/klondike.dts
    >> index 4ff2852..d5bf2e1 100644
    >> --- a/arch/powerpc/boot/dts/klondike.dts
    >> +++ b/arch/powerpc/boot/dts/klondike.dts
    >> @@ -222,6 +222,30 @@
    >>                               #size-cells = <1>;
    >>                               ranges;
    >>                               clock-frequency = <0>;
    >> +
    >> +                             UART0: serial@50001000 {
    >> +                                    device_type = "serial";
    >> +                                    compatible = "ns16550";
    >> +                                    reg = <0x50001000 0x00000100>;
    >> +                                    virtual-reg = <0x50001000>;
    >
    > Why do you need virtual-reg?  The kernel should handle all iomapping
    > properly without this.

    Right. It's been used for platforms that actually use the
    zImage/treeImage wrapper for printf support, but this uses u-boot as
    far as I know. It shouldn't need it.

    josh
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-04 02:51    [W:0.027 / U:1.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site