Messages in this thread | | | Date | Wed, 4 Apr 2012 00:26:25 +0200 | From | Jan Seiffert <> | Subject | Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits |
| |
David Miller schrieb: > From: Jan Seiffert <kaffeemonster@googlemail.com> > Date: Fri, 30 Mar 2012 17:08:19 +0200 > >> The function is renamed to make it a little more clear what it does. >> It is not added to any .h because it is not for general consumption, only for >> bpf internal use (and so by the jits). >> >> Signed-of-by: Jan Seiffert <kaffeemonster@googlemail.com> > > Applied but with comment formatting fixed up: > >> +/* >> + * No hurry in this branch >> + * >> + * Exported for the bpf jit load helper. >> + */ > > Like this: > >> +/* No hurry in this branch >> + * >> + * Exported for the bpf jit load helper. >> + */ >
Thanks David!
I was planning on a V5 for the little things i did wrong (wrong patch separator, etc.) but wanted to wait a little more for more feedback.
Is that the preferred comment style in net/ ? Coding style says first line empty. Or just to match the rest of the file?
Greetings Jan
| |