Messages in this thread | | | Date | Tue, 3 Apr 2012 11:55:47 -0700 | From | Stephen Hemminger <> | Subject | Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() |
| |
On Fri, 30 Mar 2012 19:36:16 +0200 Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote:
> In sky2_test_msi() the temporarily set SW IRQ in B0 register is not reset in case > that request_irq() fails. > With this patch we only set the interrupt mask if request_irq() was successful. > > Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Ok, but this is a non-serious error case. If request_irq() fails here, the driver is going to fail to load and on the failure path of sky2_probe will reset the chip on the way out.
| |