Messages in this thread | | | Date | Tue, 03 Apr 2012 09:10:31 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [RFC PATCH -tip 00/16] in-kernel x86 disassember |
| |
On 04/03/2012 12:31 AM, Ingo Molnar wrote: > > The existing oops setup knob is an early_param() in > kernel/panic.c, "oops=". > > I'd suggesting extending that in an obvious way. Currently the > only option that exists is "oops=panic", so a comma delimited > list of attributes would be the natural extension, allowing: > > oops=panic > oops=panic,disasm > oops=disasm > > Detail: it should do a strncmp(5, str, "disas"), so that every > usual variant works: oops=disasm, oops=disassemble, etc. > >> [...] In other words, if *you* are debugging your own kernel, >> and don't expect to ship oopses off to someone else. > > Probably a DEBUG .config option as well, so that distros can > enable it. OTOH, CONFIG_CMDLINE allows the setting of such > parameters as well. >
I would say there should be a CONFIG option to build it in, but I'd like to see an explicit command-line option to enable it.
I *do not* want to see this in distro kernels. That is all downside.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |