[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v6 0/2] Ethernet drivers for WIZnet chips
    On Tue, 2012-04-03 at 16:58 +0600, Mike Sinkovsky wrote:
    > Based on original driver from chip manufacturer, but nearly full rewite.
    > Tested and used in production with Blackfin BF531 embedded processor.
    > Signed-off-by: Mike Sinkovsky <>
    > ---
    > v6:
    > - remove (S0_TX_FSR < skb->len) check in TX handler, it doesn't work
    > anyway. Chip can transmit only one frame with MTU 1500 at a time,
    > and tx buffer size is bigger.

    So what happens if XXX frames are given to start_xmit() in a flood ?

    You removed any flow control, how can this work ?

    Device has an infinite queue ?

     \ /
      Last update: 2012-04-03 13:41    [W:0.018 / U:54.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site