lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 0/2] Ethernet drivers for WIZnet chips
From
Date
On Tue, 2012-04-03 at 16:58 +0600, Mike Sinkovsky wrote:
> Based on original driver from chip manufacturer, but nearly full rewite.
> Tested and used in production with Blackfin BF531 embedded processor.
>
> Signed-off-by: Mike Sinkovsky <msink@permonline.ru>
> ---
> v6:
> - remove (S0_TX_FSR < skb->len) check in TX handler, it doesn't work
> anyway. Chip can transmit only one frame with MTU 1500 at a time,
> and tx buffer size is bigger.

So what happens if XXX frames are given to start_xmit() in a flood ?

You removed any flow control, how can this work ?

Device has an infinite queue ?




\
 
 \ /
  Last update: 2012-04-03 13:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site