lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] serial: 8250: Add cpufreq support
    > This patch was submitted 2 years ago but didn't make it to the mainline. Now i am reposting it.

    Can you fix it instead of just reposting it ?


    > +#ifdef CONFIG_CPU_FREQ
    > +static int serial8250_cpufreq_transition(struct notifier_block *nb,
    > + unsigned long val, void *data)
    > +{
    > + struct uart_8250_port *p;
    > + struct uart_port *uport;

    What is your locking model ?


    > +static inline void serial8250_cpufreq_deregister(struct uart_8250_port *p)

    unregister

    > + ret = serial8250_cpufreq_register(uart);
    > + if (ret < 0)
    > + printk(KERN_ERR "Failed to add cpufreq notifier\n");

    Why do this for devices that don't care.

    Alan


    \
     
     \ /
      Last update: 2012-04-03 11:55    [W:0.018 / U:11.896 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site