lkml.org 
[lkml]   [2012]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: autofs: make the autofsv5 packet file descriptor use a packetized pipe
    On Sun, Apr 29, 2012 at 6:29 PM, Ian Kent <raven@themaw.net> wrote:
    >
    > autodir looks ok as well.
    >
    > http://sourceforge.net/projects/intraperson/files/latest/download

    That looks odd, but safe.

    Why does the code make the pipe file descriptor non-blocking, when it
    then always reads it using that odd "poll_read()" function that does a
    loop with poll() and read(). I guess there is some 1-second timeout
    thing.

    It's a bit odd in other ways too. The "handle_events()" function is
    passed the fd, but then it never actually uses it, and uses
    'autodir.k_pipe' instead.

    So I'm having a bit of trouble following the *logic* to any of that,
    but the only reads I found did seem to match the "read whole packet"
    model, so it does look ok too.

    Linus


    \
     
     \ /
      Last update: 2012-04-30 04:21    [W:0.027 / U:30.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site