lkml.org 
[lkml]   [2012]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 1/5] x86: Move per cpu cpu_llc_shared_map to a field in struct cpuinfo_x86
    On 04/29/2012 04:33 PM, Kevin Winchester wrote:
    > Commit 141168c36cde ("x86: Simplify code by removing a !SMP #ifdefs from
    > 'struct cpuinfo_x86'") caused the compilation error:
    >
    > mce_amd.c:(.cpuinit.text+0x4723): undefined reference to 'cpu_llc_shared_map'
    >
    > by removing an #ifdef CONFIG_SMP around a block containing a reference
    > to cpu_llc_shared_map. Rather than replace the #ifdef, move
    > cpu_llc_shared_map to be a new cpumask_t field llc_shared_map in
    > struct cpuinfo_x86 and adjust all references to cpu_llc_shared_map.
    >

    Okay... I must not get this.

    Why is this better than just moving the DEFINE_PER_CPU to a place which
    isn't dependent on SMP?

    -hpa


    --
    H. Peter Anvin, Intel Open Source Technology Center
    I work for Intel. I don't speak on their behalf.



    \
     
     \ /
      Last update: 2012-04-30 01:41    [W:0.026 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site