lkml.org 
[lkml]   [2012]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] mfd: add LM3533 lighting-power core driver
On Fri, Apr 20, 2012 at 05:30:23PM +0200, Johan Hovold wrote:

> +static int __lm3533_read(struct lm3533 *lm3533, u8 reg, u8 *val)
> +{
> + int ret;
> +
> + ret = lm3533->read(lm3533, reg, val);
> + if (ret < 0) {

Looks like you could save a bunch of code by using regmap for the
register I/O. This would also give you access to the cache and
diagnostic infrastructure it has.


\
 
 \ /
  Last update: 2012-04-26 14:47    [W:0.351 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site