lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [TMP] OMAP3EVM: Test gpmc nand & smsc911x
    * Afzal Mohammed <afzal@ti.com> [120405 09:08]:
    > @@ -114,6 +147,8 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
    >
    > static inline void __init omap3evm_init_smsc911x(void)
    > {
    > + struct gpmc_device_pdata *gpmc_smsc911x_info;
    > +
    > /* Configure ethernet controller reset gpio */
    > if (cpu_is_omap3430()) {
    > if (get_omap3_evm_rev() == OMAP3EVM_BOARD_GEN_1)
    > @@ -122,7 +157,11 @@ static inline void __init omap3evm_init_smsc911x(void)
    > smsc911x_cfg.gpio_reset = OMAP3EVM_GEN2_ETHR_GPIO_RST;
    > }
    >
    > - gpmc_smsc911x_init(&smsc911x_cfg);
    > + gpmc_smsc911x_info = gpmc_smsc911x_init(&smsc911x_cfg);
    > + if (gpmc_smsc911x_info)
    > + *gpmc_data_cur++ = gpmc_smsc911x_info;
    > + else
    > + pr_err("error: unable to initilaize gpmc smsc911x\n");
    > }
    >
    > #else

    Obviously we can't merge any of this if until all the board-*.c files
    are changed and tested.

    Can you maybe still keep the old interfaces in addition to the new ones
    so we can do the conversion one board-*.c file at a time while keeping
    things working?

    Regards,

    Tony


    \
     
     \ /
      Last update: 2012-04-25 18:49    [W:0.037 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site