lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] mfd: tps65090: Return proper error if regmap_init_i2c fails
Thanks for the patch.
Acked by: Venu Byravarasu<vbyravarasu@nvidia.com>
> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@gmail.com]
> Sent: Wednesday, April 25, 2012 7:01 AM
> To: linux-kernel@vger.kernel.org
> Cc: Samuel Ortiz; Venu Byravarasu
> Subject: [PATCH] mfd: tps65090: Return proper error if regmap_init_i2c fails
>
> Return proper error instead of 0 if regmap_init_i2c fails.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/tps65090.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index 47f802b..da821d9 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -286,10 +286,10 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
> tps65090->rmap = regmap_init_i2c(tps65090->client,
> &tps65090_regmap_config);
> if (IS_ERR(tps65090->rmap)) {
> - dev_err(&client->dev, "regmap_init failed with err: %ld\n",
> - PTR_ERR(tps65090->rmap));
> + ret = PTR_ERR(tps65090->rmap);
> + dev_err(&client->dev, "regmap_init failed with err: %d\n", ret);
> goto err_irq_exit;
> - };
> + }
>
> ret = mfd_add_devices(tps65090->dev, -1, tps65090s,
> ARRAY_SIZE(tps65090s), NULL, 0);
> --
> 1.7.5.4
>
>

\
 
 \ /
  Last update: 2012-04-25 07:33    [from the cache]
©2003-2011 Jasper Spaans