lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 1/3] ARM: tegra: Add AHB driver
    Date
    On Wednesday 25 April 2012, Felipe Balbi wrote:
    > On Wed, Apr 25, 2012 at 08:37:47AM +0300, Hiroshi Doyu wrote:
    > > On Tue, 24 Apr 2012 21:56:45 +0200
    > > Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
    > >
    > > > On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote:
    > > > > The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
    > > > > High-performance Bus (AHB) architecture.
    > > > >
    > > > > The AHB Arbiter controls AHB bus master arbitration. This effectively
    > > > > forms a second level of arbitration for access to the memory
    > > > > controller through the AHB Slave Memory device. The AHB pre-fetch
    > > > > logic can be configured to enhance performance for devices doing
    > > > > sequential access. Each AHB master is assigned to either the high or
    > > > > low priority bin. Both Tegra20/30 have this AHB bus.
    > > > >
    > > > > Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
    > > > > Cc: Felipe Balbi <balbi@ti.com>
    > > > > Cc: Arnd Bergmann <arnd@arndb.de>
    > > > > ---
    > > > > Update:
    > > > > - Use platform_device to get info from dt dynamically.(Felipe/Arnd)
    > > > > ---
    > > > > arch/arm/mach-tegra/Makefile | 1 +
    > > > > arch/arm/mach-tegra/tegra-ahb.c | 285 +++++++++++++++++++++++++++++++++++++++
    > > > > 2 files changed, 286 insertions(+), 0 deletions(-)
    > > >
    > > > 1. I thought we weren't going to have any more drivers under
    > > > arch/arm
    > >
    > > Can this driver be located under "drivers/misc"? Or is there any better place?
    >
    > maybe drivers/platform/arm/ ??

    I really wouldn't want to add that directory: It has the risk of letting
    people add random crap there that may or may not be related to ARM (the
    company) and/or ARM (the architecture).

    I think it could go into drivers/amba/ along with the primecell bus driver.
    The two drivers are for two different aspects of the AMBA spec and don't
    actually depend on one another as far as I can tell, but it's at least
    a fitting name, and it doesn't depend on the ARM architecture, which is
    important because the driver could be used on other architectures that
    are connected to an AHB bus.

    Arnd


    \
     
     \ /
      Last update: 2012-04-25 14:21    [W:0.027 / U:88.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site