Messages in this thread | | | From | "Kim, Milo" <> | Date | Tue, 24 Apr 2012 03:15:09 -0700 | Subject | RE: [PATCH] leds: lm3530: fix handling of already enabled regulators |
| |
> > Let me put it this way: Assume only this driver is using the regulator. > If the regulator is enabled on boot, which means the reference count > is init to 1. >
Could you explain what 'enabled on boot' means ? 1) The regulator_enable() is called in initial time or 2) boot_on = 1 in regulator_init_data ?
If you mean 'boot_on = 1' in regulator_init_data, then no use_count increase.
> Then if we set brt_val to 0 in lm3530_brightness_set, which will then > call > regulator_disable().
It looks buggy code in lm3530_brightness_set(). Even the regulator_disable() is failed, drvdata->enable is set to false. I think drvdata->enable is changed to false only when the regulator is off successfully.
Thanks & BR Milo - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |