lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
On Mon, Apr 23, 2012 at 08:33:50PM -0500, Seth Jennings wrote:
> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).

Hey Greg,

Please push this to your tree at your convience. linux-next
folks found this combination breaks the build ..

>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> select ZSMALLOC
> select CRYPTO_LZO
> default n
> --
> 1.7.5.4


\
 
 \ /
  Last update: 2012-04-24 04:17    [from the cache]
©2003-2011 Jasper Spaans