Messages in this thread | | | Subject | Re: [PATCH 10/11] parse-filter: Fix signature of create_arg_item() | From | Steven Rostedt <> | Date | Mon, 23 Apr 2012 14:57:14 -0400 |
| |
On Mon, 2012-04-23 at 13:58 +0900, Namhyung Kim wrote: > The @type should be a type of enum event_type not enum > filter_arg_type. This fixes following warning: > > $ make > COMPILE FPIC parse-events.o > COMPILE FPIC parse-filter.o > /home/namhyung/project/trace-cmd/parse-filter.c: In function ‘create_arg_item’: > /home/namhyung/project/trace-cmd/parse-filter.c:343:9: warning: comparison between ‘enum filter_arg_type’ and ‘enum event_type’ [-Wenum-compare] > /home/namhyung/project/trace-cmd/parse-filter.c:339:2: warning: case value ‘8’ not in enumerated type ‘enum filter_arg_type’ [-Wswitch] > BUILD STATIC LIB libparsevent.a > BUILD STATIC LIB libtracecmd.a > BUILD trace-cmd > /usr/bin/make -C /home/namhyung/project/trace-cmd/Documentation all > make[1]: Nothing to be done for `all'. > Note: to build the gui, type "make gui"
Applied thanks!
-- Steve
> > Signed-off-by: Namhyung Kim <namhyung.kim@lge.com> > --- > parse-filter.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/parse-filter.c b/parse-filter.c > index 0e6c0b1..fa6e6a2 100644 > --- a/parse-filter.c > +++ b/parse-filter.c > @@ -325,9 +325,8 @@ static void free_events(struct event_list *events) > } > > static struct filter_arg * > -create_arg_item(struct event_format *event, > - const char *token, enum filter_arg_type type, > - char **error_str) > +create_arg_item(struct event_format *event, const char *token, > + enum event_type type, char **error_str) > { > struct format_field *field; > struct filter_arg *arg;
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |