Messages in this thread | | | Subject | Re: [PATCH 09/11] parse-filter: Check result of malloc() during reading token | From | Steven Rostedt <> | Date | Mon, 23 Apr 2012 14:48:37 -0400 |
| |
On Mon, 2012-04-23 at 13:58 +0900, Namhyung Kim wrote: > The malloc can fail so the return value should be checked. > For now, just use malloc_or_die().
Applied, thanks!
Although we will be getting rid of the 'die' feature. But at least this marks a location that we need to track.
-- Steve
> > Signed-off-by: Namhyung Kim <namhyung.kim@lge.com> > --- > parse-filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parse-filter.c b/parse-filter.c > index bc62f1f..0e6c0b1 100644 > --- a/parse-filter.c > +++ b/parse-filter.c > @@ -96,7 +96,7 @@ static enum event_type read_token(char **tok) > (strcmp(token, "=") == 0 || strcmp(token, "!") == 0) && > pevent_peek_char() == '~') { > /* append it */ > - *tok = malloc(3); > + *tok = malloc_or_die(3); > sprintf(*tok, "%c%c", *token, '~'); > free_token(token); > /* Now remove the '~' from the buffer */
| |