[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC] TIF_NOTIFY_RESUME, arch/*/*/*signal*.c and all such
    On 04/23, Al Viro wrote:
    > On Fri, Apr 20, 2012 at 07:07:48PM +0100, Al Viro wrote:
    > > On Fri, Apr 20, 2012 at 10:21:35AM -0700, Linus Torvalds wrote:
    > > > This is why I suggested you look at Oleg's patches. If we guarantee
    > > > that things won't be delayed past re-entering user mode, all those
    > > > issues go away.
    > >
    > > I've looked at them. One obvious problem is that it tracehook_notify_resume()
    > > is not universally called. AFAICS, hexagon, m68k, microblaze, score, um
    > > and xtensa never call tracehook_notify_resume().


    > > Out of those, hexagon is
    > > manually checking TIF_NOTIFY_RESUME and does key_replace_session_keyring(),
    > > so the call could be easily added into the same place;

    Yes, I sent the trivial patch.

    > > the rest of those
    > > guys don't even look at TIF_NOTIFY_RESUME anywhere near their signal*.c
    > > and m68k/um/xtensa don't even have it defined, let alone handled. So this
    > > stuff depends on some amount of asm glue hacking on several architectures ;-/

    which I don't understand even remotely :/ But I'll try to understand at
    least something.

    > Oleg, where does your tree live?

    Cough. Nowhere. I still can't restore my korg account.

    > I've walked through the signal handling
    > on all targets over this weekend (and it's still not complete - there are
    > fun bugs re multiple sigframes and restart handling on many of those) and
    > my current queue is at;

    Thanks. I don't think you need my help, but I'll certainly try to look this
    week anyway.


     \ /
      Last update: 2012-04-23 20:41    [W:0.023 / U:12.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site