lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/16] sched: SCHED_DEADLINE policy implementation.
From
Date
On Mon, 2012-04-23 at 16:43 +0200, Juri Lelli wrote:
>
> > From what I can see there are no constraints on the values in
> > __setparam_dl() so the above left term can be constructed to be an
> > overflow.
> >
>
> Yes, could happen :-\.
>
> > Ideally we'd use u128 here, but I don't think people will let us :/
> >
>
> Do we need to do something about that? If we cannot go for bigger space
> probably limit dl_deadline (or warn the user)..

Depends on what happens, if only this task gets screwy, no real problem,
they supplied funny input, they get funny output. If OTOH it affects
other tasks we should do something.

Ideally we'd avoid the situation by some clever maths, second best would
be rejecting the parameters up front.


\
 
 \ /
  Last update: 2012-04-23 17:15    [from the cache]
©2003-2011 Jasper Spaans