lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH RFC 1/5] apic: fix typo EIO_ACK -> EOI_ACK and document
    Fix typo in the macro name and document the
    reason it has this value. Update users.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---
    arch/x86/include/asm/apicdef.h | 2 +-
    arch/x86/platform/visws/visws_quirks.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)
    diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h
    index 134bba0..c46bb99 100644
    --- a/arch/x86/include/asm/apicdef.h
    +++ b/arch/x86/include/asm/apicdef.h
    @@ -37,7 +37,7 @@
    #define APIC_ARBPRI_MASK 0xFFu
    #define APIC_PROCPRI 0xA0
    #define APIC_EOI 0xB0
    -#define APIC_EIO_ACK 0x0
    +#define APIC_EOI_ACK 0x0 /* Docs say 0 for future compat. */
    #define APIC_RRR 0xC0
    #define APIC_LDR 0xD0
    #define APIC_LDR_MASK (0xFFu << 24)
    diff --git a/arch/x86/platform/visws/visws_quirks.c b/arch/x86/platform/visws/visws_quirks.c
    index c7abf13..94d8a39 100644
    --- a/arch/x86/platform/visws/visws_quirks.c
    +++ b/arch/x86/platform/visws/visws_quirks.c
    @@ -445,7 +445,7 @@ static void ack_cobalt_irq(struct irq_data *data)

    spin_lock_irqsave(&cobalt_lock, flags);
    disable_cobalt_irq(data);
    - apic_write(APIC_EOI, APIC_EIO_ACK);
    + apic_write(APIC_EOI, APIC_EOI_ACK);
    spin_unlock_irqrestore(&cobalt_lock, flags);
    }

    --
    1.7.9.111.gf3fb0


    \
     
     \ /
      Last update: 2012-04-23 16:09    [from the cache]
    ©2003-2011 Jasper Spaans