| Date | Mon, 23 Apr 2012 12:37:43 +0200 | From | Juri Lelli <> | Subject | Re: [PATCH 05/16] sched: SCHED_DEADLINE policy implementation. |
| |
On 04/23/2012 12:31 PM, Peter Zijlstra wrote: > On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote: >> + dl_se->deadline = rq->clock + dl_se->dl_deadline; > > You might want to use rq->clock_task, this clock excludes times spend in > hardirq context and steal-time (when paravirt). > > Then again, it might not want to use that.. but its something you might > want to consider and make explicit by means of a comment.
Yes, I planned a consistency check for the use of clock/clock_task throughout the code, but it seems I then forgot it. Planned for the next iteration :-).
Thanks,
- Juri
|