Messages in this thread | | | From | Hui Zhu <> | Date | Sun, 22 Apr 2012 13:17:54 +0800 | Subject | Re: KGTP (Linux Kernel debugger and tracer) 20120406 release(hotcode analyzer hotcode.py can output html) include patch for review |
| |
Hi Geoff,
On Wed, Apr 18, 2012 at 09:05, Geoff Levand <geoff@infradead.org> wrote: > Hi Hui, > > On Sat, 2012-04-07 at 20:21 +0800, Hui Zhu wrote: >> Signed-off-by: Hui Zhu <teawater@gmail.com> > > You have done some interesting work, but can I recommend a > few things? > > Please break your patch into a few smaller ones, say, one > that adds the core kgtp support, one that adds the > documentation files, one that adds the scripts. Each patch > should have a suitable comment that describes the > changes. For kgtp the patch for the core support would > of course have a discussion of the feature and its > benefits, etc. > > Also, please post your patches inline so we can give > line-by-line comments. It is difficult to give comments > when the patch is an email attachment. >
Thanks a lot for your mail. I will do all of them according to your mail.
Best. Hui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |