Messages in this thread | | | Subject | Re: [PATCH] C6X: add support to build with BINFMT_ELF_FDPIC | From | Mark Salter <> | Date | Sun, 22 Apr 2012 17:21:18 -0400 |
| |
On Sat, 2012-04-21 at 01:01 -0400, Mike Frysinger wrote: > On Fri, Apr 20, 2012 at 17:47, Mark Salter wrote: > > --- a/arch/c6x/kernel/process.c > > +++ b/arch/c6x/kernel/process.c > > > > + > > +/* Fill in the fpu structure for a core dump. This is easy -- we don't have any */ > > +int dump_fpu(struct pt_regs *regs, elf_fpregset_t *fpu) > > +{ > > + /* Not valid */ > > + return 0; > > +} > > you could avoid this like Blackfin has: > arch/blackfin/include/asm/elf.h: > #define ELF_CORE_COPY_FPREGS(...) 0 /* Blackfin has no FPU */
Yes, thanks. That's a better way I missed.
> > > --- a/fs/Kconfig.binfmt > > +++ b/fs/Kconfig.binfmt > > > > config BINFMT_ELF_FDPIC > > bool "Kernel support for FDPIC ELF binaries" > > default y > > - depends on (FRV || BLACKFIN || (SUPERH32 && !MMU)) > > + depends on (FRV || BLACKFIN || (SUPERH32 && !MMU) || TMS320C6X) > > shouldn't the main arch symbol be "C6X" to match arch/c6x/ ?
It probably should have been. Most architectures use that convention but there are notable exceptions like powerpc and sh.
> -mike
| |