lkml.org 
[lkml]   [2012]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Multitouch regression in 3.3 on thinkpad X220 clickpad
On Sat, Apr 21, 2012 at 10:16:40AM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-04-20 at 10:01 -0700, Dmitry Torokhov wrote:
>
> > It looks we lost a condition in synaptics_set_advanced_gesture_mode().
> > It used to be:
> >
> >
> > if (!(SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) ||
> > SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c)))
> > return 0;
> >
> > and now simply is:
> >
> > if (!SYN_CAP_ADV_GESTURE(priv->ext_cap_0c))
> > return 0;
> >
> > Could you try restoring the condition and see if it fixes the
> > regression?
>
> Yes, that's it. Please shoot the patch below to Linus.
>
> Thanks,
> Ben.
>
> input/synaptics: Fix regression with "image sensor" trackpads
>
> commit 7968a5dd492ccc38345013e534ad4c8d6eb60ed1
> Input: synaptics - add support for Relative mode
>
> Accidentally broke support for advanced gestures (multitouch)
> on some trackpads such as the one in my ThinkPad X220 by
> incorretly changing the condition for enabling them. This
> restores it.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: stable@kernel.org [3.3]
>

Applied, thank you Ben.

--
Dmitry


\
 
 \ /
  Last update: 2012-04-21 08:03    [W:0.119 / U:0.600 seconds]
©2003-2011 Jasper Spaans