lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH 04/17] hpsa: suppress excessively chatty error messages
    | -----Original Message-----
    | From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
    | owner@vger.kernel.org] On Behalf Of Stephen M. Cameron
    | Sent: Friday, April 20, 2012 8:07 AM
    | To: james.bottomley@hansenpartnership.com
    | Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Gates, Matt;
    | stephenmcameron@gmail.com; thenzl@redhat.com; akpm@linux-foundation.org;
    | mikem@beardog.cce.hp.com
    | Subject: [PATCH 04/17] hpsa: suppress excessively chatty error messages
    |
    | From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    |
    | Default behavior for any CHECK CONDITION excepting a few special cases is
    | to print out certain parts of the sense buffer and the CDB. Default
    | behavior should be to print nothing and let the upper layers or
    | applications decide what to do about these. The same information is
    | already available by setting the appropriate bits of the
    | scsi_logging_level kernel parameter or via
    | /proc/sys/dev/scsi/logging_level.

    Makes sense.

    |
    | Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    | ---
    | drivers/scsi/hpsa.c | 2 +-
    | 1 files changed, 1 insertions(+), 1 deletions(-)
    |
    | diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index
    | 906672b..fcb9fb2 100644
    | --- a/drivers/scsi/hpsa.c
    | +++ b/drivers/scsi/hpsa.c
    | @@ -1193,7 +1193,7 @@ static void complete_scsi_command(struct CommandList
    | *cp)
    | break;
    | }
    | /* Must be some other type of check condition */
    | - dev_warn(&h->pdev->dev, "cp %p has check condition: "
    | + dev_dbg(&h->pdev->dev, "cp %p has check condition: "
    | "unknown type: "
    | "Sense: 0x%x, ASC: 0x%x, ASCQ: 0x%x, "
    | "Returning result: 0x%x, "
    |

    Few lines further down in the same function, there is another dev_warn() for SCSI errors.

    /* Problem was not a check condition
    * Pass it up to the upper layers...
    */
    if (ei->ScsiStatus) {
    dev_warn(&h->pdev->dev, "cp %p has status 0x%x "
    "Sense: 0x%x, ASC: 0x%x, ASCQ: 0x%x, "


    I am wondering whether it make sense to make the same change here as well as. This will suppress logging for other SCSI status, for example BUSY, TASK SET FULL, etc.

    Sunny

    \
     
     \ /
      Last update: 2012-04-21 00:55    [W:0.051 / U:60.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site