lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] android-alarm: Rework alarm-dev.c to use upstreamed alarmtimers
    On Fri, Apr 20, 2012 at 12:31:46PM -0700, John Stultz wrote:
    > This reworks the alarm-dev.c to use the upstreamed alarmtimers
    > interface.
    >
    > CC: Colin Cross <ccross@android.com>
    > CC: Thomas Gleixner <tglx@linutronix.de>
    > CC: Android Kernel Team <kernel-team@android.com>
    > Signed-off-by: John Stultz <john.stultz@linaro.org>
    > ---
    > drivers/staging/android/alarm-dev.c | 108 +++++++++++++++++++++++++++++++---
    > 1 files changed, 98 insertions(+), 10 deletions(-)

    After this patch, I get the following warnings:

    CC drivers/staging/android/alarm-dev.o
    drivers/staging/android/alarm-dev.c: In function ‘devalarm_start’:
    drivers/staging/android/alarm-dev.c:93:3: warning: passing argument 1 of ‘alarm_start’ from incompatible pointer type [enabled by default]
    include/linux/alarmtimer.h:46:6: note: expected ‘struct alarm *’ but argument is of type ‘struct android_alarm *’
    drivers/staging/android/alarm-dev.c: In function ‘alarm_dev_init’:
    drivers/staging/android/alarm-dev.c:354:2: warning: passing argument 3 of ‘android_alarm_init’ from incompatible pointer type [enabled by default]
    drivers/staging/android/android_alarm.h:69:6: note: expected ‘void (*)(struct android_alarm *)’ but argument is of type ‘enum alarmtimer_restart (*)(struct android_alarm *, union ktime_t)’
    drivers/staging/android/alarm-dev.c:358:2: warning: passing argument 3 of ‘android_alarm_init’ from incompatible pointer type [enabled by default]
    drivers/staging/android/android_alarm.h:69:6: note: expected ‘void (*)(struct android_alarm *)’ but argument is of type ‘enum alarmtimer_restart (*)(struct android_alarm *, union ktime_t)’

    Care to send a patch that fixes this up as well, as odds are, something just
    went wrong...

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-21 00:05    [W:0.026 / U:0.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site