Messages in this thread |  | | | Date | Fri, 20 Apr 2012 17:03:48 +0300 | | From | Dan Carpenter <> | | Subject | Re: [patch] tracing: Remove an unneeded check |
| |
On Fri, Apr 20, 2012 at 09:51:21AM -0400, Steven Rostedt wrote: > On Fri, 2012-04-20 at 09:31 +0300, Dan Carpenter wrote: > > memcpy() returns a pointer to "bug". Hopefully, it's not NULL here or > > we would already have Oopsed. > > You're right that the ret is useless, and the real bug was already fixed > (the possibility that buf could be an invalid pointer). > > Not only is this needed, but also get rid of the ret < 0 check in > tracing_splice_read_pipe(). >
We still return -EBUSY so we need the check.
regards, dan carpenter
|  |