Messages in this thread | | | Subject | Re: [PATCH] printk(): add KERN_CONT where needed | From | Joe Perches <> | Date | Mon, 02 Apr 2012 20:47:45 -0700 |
| |
On Tue, 2012-04-03 at 05:00 +0200, Kay Sievers wrote: > On Tue, Apr 3, 2012 at 04:36, Joe Perches <joe@perches.com> wrote: > > A couple of other trivial comments: > > It's better to try to coalesce multiple printks(KERN_CONT > > (perhaps it's better to use pr_cont instead too) > > Branches with the same printks should be hoisted where > > possible. > Sure, please send patches for anything that is more appropriate to use here. > I did not want to change any logic which needs to be tested. I just > trivially added the obviously missing prefix, which solved the > problem, and which could be applied right away.
I think you should do it "right" rather than add trivial markers.
| |