lkml.org 
[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] phonet: Check input from user before allocating
    From
    From: "Rémi Denis-Courmont" <remi@remlab.net>
    Date: Mon, 2 Apr 2012 22:01:40 +0300

    > Le lundi 2 avril 2012 23:31:00 Sasha Levin, vous avez écrit :
    >> A phonet packet is limited to USHRT_MAX bytes, this is never checked during
    >> tx which means that the user can specify any size he wishes, and the kernel
    >> will attempt to allocate that size.
    >
    > Does this really solve the problem? I guess 128kb is still possible with
    > USHRT_MAX plus skbuff overhead, which might still trigger OOM relatively
    > easily once the memory gets sufficiently fragmented.
    >
    > How does UDP deal with this?

    UDP generates a fragment list of MTU sized SKBs.

    Phonet could avoid the large allocations by building page based
    SKBs.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-02 23:43    [W:0.019 / U:154.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site