Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 4/7] arm: mach-pnx4008: Adjust i2c.c to updated i2c-pnx.c | Date | Mon, 2 Apr 2012 13:07:15 +0000 |
| |
On Monday 02 April 2012, Roland Stigge wrote: > The i2c bus driver i2c-pnx.c (used by mach-pnx4008 and mach-lpc32xx) was > updated to support device tree. In this process, the struct i2c_pnx_data was > eliminated. Therefore, the platform data of pnx4008 is adjusted with this patch > to use default resources for mem and irq. DT support for pnx4008 is still not > available, but i2c-pnx.c now supports both DT and non-DT. > > arch/arm/mach-pnx4008/include/mach/i2c.h can safely be removed now since its > contents is integrated in the updated i2c-pnx.c driver and was duplicated > between platforms pnx4008 and lpc32xx. > > Signed-off-by: Roland Stigge <stigge@antcom.de>
Hi Roland,
The i2c changes look ok, but the order breaks bisection through the series.
Since the changes in pnx4008 are fairly localized, I would suggest merging all three patches through the i2c tree and reorganizing the changes so that each change is atomic. I would suggest an order like:
1. fix suspend 2. move contents of mach/i2c.h from pnx4008 and lpc32xx to i2c driver 3. change driver and platform device definitions to use resources instead of platform data 4. add support for device tree based probing
Arnd
| |