lkml.org 
[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits
    David Laight schrieb:
    >
    >> The function is renamed to make it a little more clear what it does.
    >> It is not added to any .h because it is not for general
    >> consumption, only for bpf internal use (and so by the jits).
    >
    > I'd have thought it better to put in into a bfp_internal.h
    > (or similar) with a big warning there about the asm users.
    >

    Hmmm, OK, where would i put the .h? Right there under ./include/linux/?

    > Possibly even worth adding some other defs that the asm
    > files will need (if there are any).
    >

    There is at least one other define, the lowest negative address range,
    but it would be a copy of the same define in filter.h, or i would have
    to massage filter.h to make it fit for inclusion by assembly.
    So I'm unsure how to proceed.

    > David
    >

    Greetings
    Jan

    --
    An IPv4 address space walks into a bar: "A strong CIDR please. I'm
    exhausted."


    \
     
     \ /
      Last update: 2012-04-02 15:05    [W:0.056 / U:30.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site