Messages in this thread Patch in this message | | | Date | Thu, 19 Apr 2012 14:04:03 -0700 | From | Greg KH <> | Subject | [ 60/75] fcaps: clear the same personality flags as suid when fcaps are used |
| |
3.3-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Paris <eparis@redhat.com>
commit d52fc5dde171f030170a6cb78034d166b13c9445 upstream.
If a process increases permissions using fcaps all of the dangerous personality flags which are cleared for suid apps should also be cleared. Thus programs given priviledge with fcaps will continue to have address space randomization enabled even if the parent tried to disable it to make it easier to attack.
Signed-off-by: Eric Paris <eparis@redhat.com> Reviewed-by: Serge Hallyn <serge.hallyn@canonical.com> Signed-off-by: James Morris <james.l.morris@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- security/commoncap.c | 5 +++++ 1 file changed, 5 insertions(+)
--- a/security/commoncap.c +++ b/security/commoncap.c @@ -504,6 +504,11 @@ int cap_bprm_set_creds(struct linux_binp } skip: + /* if we have fs caps, clear dangerous personality flags */ + if (!cap_issubset(new->cap_permitted, old->cap_permitted)) + bprm->per_clear |= PER_CLEAR_ON_SETID; + + /* Don't let someone trace a set[ug]id/setpcap binary with the revised * credentials unless they have the appropriate permit */
| |