lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] cpu: remove some dead code in store_cache_disable()
    amd_set_l3_disable_slot() never returns -EEXIST, it only returns -EINVAL
    or zero.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

    diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
    index 73d08ed..7b4e294 100644
    --- a/arch/x86/kernel/cpu/intel_cacheinfo.c
    +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
    @@ -466,12 +466,9 @@ static ssize_t store_cache_disable(struct _cpuid4_info *this_leaf,
    return -EINVAL;

    err = amd_set_l3_disable_slot(this_leaf->base.nb, cpu, slot, val);
    - if (err) {
    - if (err == -EEXIST)
    - printk(KERN_WARNING "L3 disable slot %d in use!\n",
    - slot);
    + if (err)
    return err;
    - }
    +
    return count;
    }


    \
     
     \ /
      Last update: 2012-04-19 09:07    [W:0.024 / U:30.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site